Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore unit tests #177

Merged
merged 14 commits into from
Nov 28, 2024
Merged

Restore unit tests #177

merged 14 commits into from
Nov 28, 2024

Conversation

salbahra
Copy link
Member

Changes Proposed

  • Apply suggested lint fixes to resolve all warnings
  • Move unit testing to Karma
  • Resolve issues with unit tests (some changes still pending)

Demo Video or Screenshots

Please include a short video or screenshot(s) to assist with pr review

@salbahra salbahra changed the title Bug/fix lint warnings Restore unit tests Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Visit the preview URL for this PR (updated for commit 509c403):

https://opensprinkler-devui--pr177-bug-fix-lint-warning-g0a68qaa.web.app

(expires Thu, 05 Dec 2024 15:33:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9b7a984849dffe48c01bc0242f5c0f93b14ed1df

@salbahra salbahra merged commit 984476b into master Nov 28, 2024
3 checks passed
@salbahra salbahra deleted the bug/fix-lint-warnings branch November 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant