Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): replace npm with pnpm #172

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/firebase-hosting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,22 @@ jobs:
fetch-depth: 0

- name: Cache Dependencies
id: cache_npm
id: cache_pnpm
uses: actions/cache@v4
with:
path: node_modules
key: ${{ runner.os }}-npm-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-pnpm-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-npm-
${{ runner.os }}-pnpm-

- name: Enable PNPM
run: |
corepack enable
corepack prepare [email protected] --activate

- name: Install dependencies
if: steps.cache_npm.outputs.cache-hit != 'true'
run: npm install
if: steps.cache_pnpm.outputs.cache-hit != 'true'
run: pnpm install

- name: Build UI
run: npx grunt prepareFW
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,14 @@ jobs:
with:
node-version: 18.x

- name: Enable PNPM
run: |
corepack enable
corepack prepare [email protected] --activate

- name: Install dependencies
run: |
npm install
pnpm install

- name: Run test steps
run: |
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ Please ensure your code adheres to the existing coding style and includes tests

## Local Development

Fork this repository then:
Fork this repository then [install pnpm](https://pnpm.io/installation). Next, install the dependencies and start the dev web server with:

```bash
$ npm install
$ npm start
$ pnpm install
$ pnpm start
```

From here you can open your browser to `http://localhost:8080` and begin your development.
Expand Down
4 changes: 2 additions & 2 deletions config.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8'?>
<widget android-versionCode="119" id="com.albahra.sprinklers" version="2.4.7" versionCode="120" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<widget android-versionCode="120" id="com.albahra.sprinklers" version="2.4.8" versionCode="121" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<name>OpenSprinkler</name>
<description>
Designed to allow intuitive control of the OpenSprinkler irrigation controller.
Expand Down Expand Up @@ -42,7 +42,7 @@
<string>Your camera is used to provide an image for your stations.</string>
</config-file>
<config-file target="*-Info.plist" overwrite="true" parent="CFBundleShortVersionString">
<string>196006</string>
<string>197006</string>
</config-file>
<config-file target="*-Info.plist" overwrite="true" parent="LSApplicationCategoryType">
<string>public.app-category.utilities</string>
Expand Down
Loading
Loading