Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module gallery #321

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Add module gallery #321

merged 4 commits into from
Jun 21, 2023

Conversation

armandfardeau
Copy link
Collaborator

🎩 Description

Add module gallery

📌 Related Issues

Tasks

  • In case of new dependencies or version bump, update related documentation

@armandfardeau armandfardeau requested review from a team, Ouardaoubahri and Quentinchampenois and removed request for a team June 12, 2023 15:26
@armandfardeau armandfardeau marked this pull request as ready for review June 12, 2023 15:34
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.34 ⚠️

Comparison is base (39fffd4) 73.51% compared to head (2d4dc87) 73.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #321      +/-   ##
===========================================
- Coverage    73.51%   73.18%   -0.34%     
===========================================
  Files           64       63       -1     
  Lines         1752     1667      -85     
===========================================
- Hits          1288     1220      -68     
+ Misses         464      447      -17     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@armandfardeau armandfardeau marked this pull request as draft June 12, 2023 15:41
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Jun 13, 2023

Wait for mainio/decidim-module-term_customizer#103 to be merged and backported
Depends on decidim/decidim#10993

@paulinebessoles paulinebessoles marked this pull request as ready for review June 21, 2023 09:41
@paulinebessoles paulinebessoles requested review from moustachu, paulinebessoles, a team and Quentinchampenois and removed request for a team June 21, 2023 10:18
@paulinebessoles paulinebessoles removed the request for review from moustachu June 21, 2023 14:00
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must update the decidim-term_customizer source once fixed

@Quentinchampenois Quentinchampenois merged commit fcbf592 into develop Jun 21, 2023
@Quentinchampenois Quentinchampenois deleted the feature/add-gallery branch June 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants