Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSP now using Maven #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

OSP now using Maven #2

wants to merge 5 commits into from

Conversation

buffetboy2001
Copy link

Hello, I've added Apache Maven to my fork of OSP. I'd love to see this pull request accepted and for the official OSP project move to Maven for software management. No code changed in my commits, but I did move folders around to conform to Maven best practices (hence the large number of "file changes" listed by git).

Thank you.

@dobrown
Copy link
Member

dobrown commented Nov 17, 2014

Hi Stuart, Thanks for your pull request--I'll look at it this week. None
of the OSP developers have much experience yet with maven, so we'll have
to learn more about how this change works with Eclipse. What are the
advantages of this change? Are there any disadvantages? Doug

On 11/16/2014 6:37 PM, Stuart Bowman wrote:

Hello, I've added Apache Maven to my fork of OSP. I'd love to see this
pull request accepted and for the official OSP project move to Maven
for software management. No code changed in my commits, but I did move
folders around to conform to Maven best practices (hence the large
number of "file changes" listed by git).

Thank you.

    You can merge this Pull Request by running

git pull https://github.com/buffetboy2001/osp master

Or view, comment on, or merge it at:

#2

    Commit Summary

—
Reply to this email directly or view it on GitHub
#2.

@buffetboy2001
Copy link
Author

Hey Doug, glad you're interested.

Maven quick overview. It's a software management application from the
Apache Foundation (http://maven.apache.org/). It's two main goals are
dependency management and release management. To accomplish these, an XML
file called the POM is added to the root of the project. The file describes
many things, but most importantly the artifact and version that results
from a build operation (e.g. a jar @ version x.y.z), the dependencies
necessary to build the project, and the server the dependencies can be
found on. (Apache hosts Maven Central (maven.org) that is the default
server for dependency artifacts.) When it comes time for a maven-managed
project to release an update, the idea is that maven can also deploy the
artifact(s) to Maven Central so that the world can find & download them.

Why use Maven? Well, it automates a ton of software management stuff. Yay.
Then, there is the reality that there is an enormous amount of inertia
behind the Java development community using Maven. So far as I can tell,
anything open source of any sort is found in their repository. This isn't
so much about following the crowd as it is about realizing that the crowd
is onto a good thing.

FYI: if you decide to go this route, there are still some minor clean-up
items to be done before accepting the pull request. But, that's simple to
work out.

If you'd like to see an example Maven project that is using OSP and a
dependency from Maven Central, feel free to fork this repo:
https://github.com/buffetboy2001/InvertedPendulumControlExample.

-Stuart

On Mon, Nov 17, 2014 at 3:46 PM, Douglas Brown [email protected]
wrote:

Hi Stuart, Thanks for your pull request--I'll look at it this week. None
of the OSP developers have much experience yet with maven, so we'll have
to learn more about how this change works with Eclipse. What are the
advantages of this change? Are there any disadvantages? Doug

On 11/16/2014 6:37 PM, Stuart Bowman wrote:

Hello, I've added Apache Maven to my fork of OSP. I'd love to see this
pull request accepted and for the official OSP project move to Maven
for software management. No code changed in my commits, but I did move
folders around to conform to Maven best practices (hence the large
number of "file changes" listed by git).

Thank you.

You can merge this Pull Request by running

git pull https://github.com/buffetboy2001/osp master

Or view, comment on, or merge it at:

#2

Commit Summary

  • switched over to maven
  • ignore /target
  • for convenience, eclipse files
  • maven resources folder
  • updated version to include buffetboy2001; no idea what the version
    number should be; can't tell from OSP docs

File Changes

src/main/java/org/opensourcephysics/controls/VariableNotFoundException.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-39 (0)

src/main/java/org/opensourcephysics/davidson/applets/ApplicationApplet.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-54 (0)

src/main/java/org/opensourcephysics/desktop/ostermiller/BrowserCommandLexer.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-58 (0)

src/main/java/org/opensourcephysics/display/axes/CartesianCoordinateStringBuilder.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-153 (0)

  • R

src/main/java/org/opensourcephysics/display/axes/CartesianInteractive.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-154 (0)

src/main/java/org/opensourcephysics/display/axes/CoordinateStringBuilder.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-158 (0)

src/main/java/org/opensourcephysics/display/axes/PolarCoordinateStringBuilder.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-162 (0)

src/main/java/org/opensourcephysics/display/dialogs/AutoScaleInspector.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-168 (0)

src/main/java/org/opensourcephysics/display/dialogs/DrawingPanelInspector.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-171 (0)

src/main/java/org/opensourcephysics/display/dialogs/XMLDrawingPanelInspector.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-174 (0)

  • R

src/main/java/org/opensourcephysics/display/doc-files/drawingframe_display.gif
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-175 (0)

src/main/java/org/opensourcephysics/display2d/ComplexInterpolatedPlot.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-190 (0)

src/main/java/org/opensourcephysics/display2d/SurfacePlotMouseController.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-210 (0)

src/main/java/org/opensourcephysics/display2d/TriangularBinaryLattice.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-214 (0)

src/main/java/org/opensourcephysics/display3d/core/ElementTessellation.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-240 (0)

  • R

src/main/java/org/opensourcephysics/display3d/core/ElementTetrahedron.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-241 (0)

src/main/java/org/opensourcephysics/display3d/core/VisualizationHints.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-248 (0)

  • R

src/main/java/org/opensourcephysics/display3d/core/interaction/InteractionEvent.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-249 (0)

  • R

src/main/java/org/opensourcephysics/display3d/core/interaction/InteractionListener.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-250 (0)

  • R

src/main/java/org/opensourcephysics/display3d/core/interaction/InteractionSource.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-251 (0)

  • R

src/main/java/org/opensourcephysics/display3d/core/interaction/InteractionTarget.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-252 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/DrawingFrame3D.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-255 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/DrawingPanel3D.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-256 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/ElementCylinder.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-262 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/ElementEllipsoid.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-263 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/ElementPolygon.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-268 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/ElementSegment.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-269 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/ElementSurface.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-272 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/ElementTessellation.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-273 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/ElementTetrahedron.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-274 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/InteractionTarget.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-278 (0)

src/main/java/org/opensourcephysics/display3d/simple3d/VisualizationHints.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-283 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/ConeUtils.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-284 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/CylinderUtils.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-285 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/EllipsoidUtils.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-286 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/ShapeUtils.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-287 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/TetrahedronUtils.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-288 (0)

  • R

src/main/java/org/opensourcephysics/display3d/simple3d/utils/VectorAlgebra.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-289 (0)

src/main/java/org/opensourcephysics/ejs/control/EjsCalculationControl.java
https://github.com/OpenSourcePhysics/osp/pull/2/files#diff-297 (0)

Patch Links:

—
Reply to this email directly or view it on GitHub
#2.

—
Reply to this email directly or view it on GitHub
#2 (comment).

BobHanson added a commit that referenced this pull request Jul 10, 2020
@BobHanson
BH #2 CTRL-left mouse to add/remove points from highlighted set.
e69cc57
@danielrmeyer
Copy link

This library would be much more useful if in Maven. I have some cycles to help with the effort. Looks like this PR is getting old, is there any interest in doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buffetboy2001 @dobrown @danielrmeyer