Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed lists to tuples in ModelSpecProcessor #39

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Changed lists to tuples in ModelSpecProcessor #39

merged 3 commits into from
Oct 5, 2019

Conversation

mpetrosian
Copy link
Member

Issue #36 resolved partially, for lists.

@mpetrosian mpetrosian requested a review from janosg October 3, 2019 23:26
@janosg janosg removed their request for review October 3, 2019 23:50
@mpetrosian mpetrosian requested a review from janosg October 4, 2019 00:40
janosg
janosg requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the one little change we can merge.

skillmodels/pre_processing/model_spec_processor.py Outdated Show resolved Hide resolved
janosg
janosg approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janosg janosg merged commit fb38684 into master Oct 5, 2019
@janosg janosg deleted the tuples branch October 5, 2019 15:18
@janosg janosg mentioned this pull request Nov 7, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosg janosg janosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpetrosian @janosg