Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for mod update #130

Merged
merged 18 commits into from
Jan 4, 2025
Merged

Refactoring for mod update #130

merged 18 commits into from
Jan 4, 2025

Conversation

paoloambrosio
Copy link
Contributor

@paoloambrosio paoloambrosio commented Jul 14, 2024 •
edited
Loading

Relates to #27.

  • Change bootfiles logic to install the first package if multiple (instead of erroring)
  • Refactored ModInstaller to provide an Apply method
  • Moved installation time to mods installation state. Global kept for backward compatibility
    • On read, mod time set to global if null
    • On write, global time set to max of mod times
  • Simplified installation callbacks usage
    • Explicit backups
    • Move EnsureNotCreatedAfter into backup strategy wrapper
    • Move Whitelisted into BaseInstaller
  • Moved UI interface into separate API package
  • Code style fixes

@paoloambrosio paoloambrosio mentioned this pull request Jul 14, 2024
Draft
@paoloambrosio paoloambrosio marked this pull request as ready for review January 4, 2025 07:56
@paoloambrosio paoloambrosio merged commit f2f718d into OpenSimTools:main Jan 4, 2025
1 check passed
@paoloambrosio paoloambrosio deleted the 27-refactoring branch January 4, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paoloambrosio