[ADD] spp unique id abstract model #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
emjay0921,
gonzalesedwin1123,
jeremi and
reichie020212
4 tasks
emjay0921
approved these changes
Nov 28, 2023
jeremi
requested changes
Nov 28, 2023
spp_base/models/spp_unique_id.py
Outdated
| if not prefix: | ||
| rec.registrant_id = False | ||
| continue | ||
| registrant_id = _generate_unique_id() |
There was a problem hiding this comment.
Can we double check it has not been used by querying the DB?
There was a problem hiding this comment.
sure, I had sql constraints to guard the duplication, but if you want to, sure
spp_base/models/spp_unique_id.py
Outdated
| class SppUniqueId(models.AbstractModel): | ||
| _name = "spp.unique.id" | ||
|
|
||
| registrant_id = fields.Char( |
There was a problem hiding this comment.
maybe we rename it spp_id? (and the related methods as well)
There was a problem hiding this comment.
this will change all the adaptor as well, since we are using this field name through out all the operations, but yes, we can
jeremi
approved these changes
Dec 5, 2023
gonzalesedwin1123
approved these changes
Dec 5, 2023
reichie020212
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
related issue: https://github.com/OpenSPP/openspp-registry/issues/273