Images service #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. POST - Return uris of the Provenances 3. Possibility to add a Dataset to an already existing Provenance
annetireau
reviewed
Feb 1, 2018
| @@ -57,8 +59,9 @@ | |||
| public ArrayList<String> agronomicalObjects = new ArrayList<>(); | |||
| public String startDate; | |||
| public String endDate; | |||
| public String provenance; | |||
There was a problem hiding this comment.
Explain what "provenance" attribute represents, an uri.
| //en discuter avec Anne ? | ||
| //pour l'instant, j'ai enlevé la pagination | ||
| //\SILEX:todo | ||
|
|
||
| try (MongoCursor<Document> phenotypesCursor = phenotypesMongo.iterator()) { | ||
| while (phenotypesCursor.hasNext()) { | ||
| Document phenotypeDocument = phenotypesCursor.next(); | ||
|
|
||
| Data data = new Data(); | ||
| data.setAgronomicalObject(phenotypeDocument.getString("agronomicalObject")); |
There was a problem hiding this comment.
Maybe use constant in the header of class or a specific class.
| try (MongoCursor<Document> phenotypesCursor = phenotypesMongo.iterator()) { | ||
| while (phenotypesCursor.hasNext()) { | ||
| Document phenotypeDocument = phenotypesCursor.next(); | ||
|
|
||
| Data data = new Data(); | ||
| data.setAgronomicalObject(phenotypeDocument.getString("agronomicalObject")); | ||
| data.setDate(new SimpleDateFormat("yyyy-MM-dd").format(phenotypeDocument.getDate("date"))); // TODO: changer le format de la date pour le retour | ||
| data.setDate(new SimpleDateFormat("yyyy-MM-dd").format(phenotypeDocument.getDate("date"))); |
There was a problem hiding this comment.
Make a specific class for format of date management. Maybe propose sevral type : date, datetimestamp, datetime
| Map<String, Object> phenotypeOk = phenotypeDTO.isOk(); | ||
| /** | ||
| * check if a dataset is valid (follows rules). | ||
| * @param datasetDTO |
There was a problem hiding this comment.
Add @see to reference "rules"
| /** | ||
| * check and insert in the mongodb database a list of datasets | ||
| * @param datasetsDTO datasets to insert | ||
| * @return the insertion result |
There was a problem hiding this comment.
Add provenance return and why it's needed (to complete a dataset)
| public class ShootingConfigurationDTO extends AbstractVerifiedClass { | ||
|
|
||
| private String date; | ||
| private String position; |
There was a problem hiding this comment.
what form of position is expected, date of what ?
| // Creation date: December, 11 2017 | ||
| // Contact: [email protected], [email protected], [email protected] | ||
| // Last modification date: January, 03 2018 | ||
| // Subject: A class which allows to start a thread for image sending |
|
|
||
| final static Logger LOGGER = LoggerFactory.getLogger(ImageWaitingCheck.class); | ||
| final static String PROPS_FILE_NAME = "service"; | ||
| final static int DEFAUT_WAITING_FILE_TIME = 30; |
| import phis2ws.service.view.model.phis.ImageMetadata; | ||
|
|
||
| /** | ||
| * Allows the formating of the result of the reqyest about Image Metadata |
There was a problem hiding this comment.
"reqyest"
Maybe change brapi package ? package phis2ws.service.view.brapi.form
?issue ?
| */ | ||
| public class ImageMetadata { | ||
|
|
||
| private String uri; |
annetireau
added a commit
that referenced
this pull request
Jan 11, 2019
Jena #4 - Use Jena for Sensor Profiles INSERT and DELETE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST images metadata
POST image (file)
GET images (search by : uri, rdf type, date, concerned elements)