Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Offline pdf docs #304

Closed
wants to merge 23 commits into from
Closed

Conversation

monstajoe2002
Copy link

No description provided.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for openrefine-website ready!

Name Link
🔨 Latest commit 6bf1099
🔍 Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/65e8931e184444000804d290
😎 Deploy Preview https://deploy-preview-304--openrefine-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wetneb
Copy link
Member

wetneb commented Jun 12, 2024

Apologies in the delay for reviewing this. I don't think uploading a static PDF in this repository is a good move as it will get outdated as docs are edited.

@ostephens
Copy link
Member

ostephens commented Jun 12, 2024

Perhaps implementing a PDF generator that works with docusaurus like https://github.com/jean-humann/docs-to-pdf might be an option?

@monstajoe2002
Copy link
Author

I tried that, it's no different than the other plugin. Also, it didn't work on my machine.

@ostephens
Copy link
Member

Sorry both - I've deleted my last comment as I think it was totally wrong

@ostephens
Copy link
Member

@monstajoe2002 I agree with @wetneb uploading a static file is not a good solution here. I feel there must be a better solution - what were the issues you saw with docs-to-pdf and prince?

@ostephens
Copy link
Member

@monstajoe2002 I'd really like to support achieving your goal here, but I wonder if you could:

  • describe in more detail what your aim is (why are you adding the PDF - is it for a printable version? Or to have one that works offline?)
  • describe the issues you encountered when trying to use the plugins to automatically generate the PDF

@magdmartin
Copy link
Member

@ostephens I agree with your point. Let's keep the requirement in #275
@monstajoe2002 I am closing this PR as we refine the requirement first.

@magdmartin magdmartin closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants