Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pips #122

Closed
wants to merge 32 commits into from
Closed

Remove pips #122

wants to merge 32 commits into from

Conversation

evgeniysergeev
Copy link
Collaborator

There no such thing in original

@evgeniysergeev evgeniysergeev changed the title Remove pips for Refinery, Silo and Harvester Remove pips May 18, 2019
@MustaphaTR
Copy link
Member

There original showed the percentage for the harvester when you select it via text and silo storage on the sidebar when you select a silo or refinery tho. I'm not sure if it is a good idea to remove the pip without having this first.

@evgeniysergeev
Copy link
Collaborator Author

evgeniysergeev commented May 19, 2019 •
edited
Loading

Waiting for #124

@evgeniysergeev evgeniysergeev added the Blocked Waiting for issue or pull request label May 19, 2019
evgeniysergeev and others added 19 commits May 19, 2019 13:35
@evgeniysergeev @MustaphaTR
add wall_explosion: section in sequences/explosion.yaml
f21b316
@evgeniysergeev @MustaphaTR
Add AUTHORS
8932073 
update README.md with AUTHORS link

Update sources header with current year and d2 mod Developers

Add Credits in mod.config

update link in README.md
@evgeniysergeev
Restore 'disabled' palete
3600a2c
@evgeniysergeev
Merge pull request OpenRA#127 from evgeniysergeev/t126
43e0659 
Restore 'disabled' palete
@evgeniysergeev
Automatically download d2k content on first run
68b08f2
@evgeniysergeev
Import Original maps from SCENARIO.PAK
92614a2
@evgeniysergeev
Move smooth tile edges on map function to reusable class
e76dd2d
@evgeniysergeev
Smooth imported maps
e463715
@evgeniysergeev
Add resources to imported map
90dabfe
@evgeniysergeev
Add Additional Spice Fields to imported map
37cf96c
@evgeniysergeev
Add Spice Blooms to imported map
21a0475
@evgeniysergeev
Add Spawn Points to imported maps
9068aff
@evgeniysergeev
Update csproject, rules and ModSDK to use bleed and new engine toolchain
c54f3ef 
Fix code style and compiler errors and warnings

Fix csproj

Add default launch options for csproj file

Remove unneded reference to ingame-observerstats.yaml

Update rules

Update ModSDK to work with the new engine toolchain
@evgeniysergeev
Fix typo in D2Concrete
c465265
@abcdefg30
Merge pull request OpenRA#137 from evgeniysergeev/fix-d2concrete
391e905 
Fix typo in D2Concrete
@evgeniysergeev
Remove D2VocLoader and use VocLoader from OpenRA engine
f077555
@evgeniysergeev
Add D2BuildingPlacementRenerable and D2PlaceBuildingPreview
f104eed
@abcdefg30
Merge pull request OpenRA#136 from evgeniysergeev/buildings-placement-3
2b37e35 
Add D2BuildingPlacementRenderable and D2PlaceBuildingPreview
@evgeniysergeev
add D2Selection
04a1630
@MustaphaTR MustaphaTR mentioned this pull request Jul 10, 2019
Merged
evgeniysergeev and others added 2 commits July 16, 2019 21:12
@evgeniysergeev
Add sidebar panel with Actor info OpenRA#124
d51d587 
Add Health Bar

Add D2PanelWidget

Add update power info
@abcdefg30
Merge pull request OpenRA#143 from evgeniysergeev/t124
0a74333 
Add sidebar panel with Actor info
@phrohdoh
Copy link
Member

phrohdoh commented Sep 9, 2019

Can this be revisited now that #124 is closed?

@abcdefg30
Copy link
Member

Yes I suppose so. Harvesters however don't seem to display this information yet @evgeniysergeev.

@abcdefg30 abcdefg30 removed the Blocked Waiting for issue or pull request label Sep 10, 2019
@evgeniysergeev
Copy link
Collaborator Author

Yes I suppose so. Harvesters however don't seem to display this information yet @evgeniysergeev.

Harvester show information not on the left side(which is ready) but on top bar.
But unfortunately it is hard to draw this top bar using original resources. OpenRA engine can handle only png files for UI, but original resources is in SCP files.
So currently don’t know what to do with this

@abcdefg30
Copy link
Member

You could either try to convert the required SCP parts to PNG or add a text (like for refineries) as workaround until you can use the SCP files.

@TheRaffy
Copy link

SCP? is that a file ending?

@evgeniysergeev
Update to playtest-20190825 OpenRA engine (OpenRA#146)
f213467 
* Use playtest-20190825 engine and latest modSdk

* Update rules using ./utility.sh --update-mod release-20190314 --detailed --apply command

* Manual rules adjustments for playtest-20190825 OpenRA engine

* fix newline in mod.yaml
@evgeniysergeev
Remove pips for Refinery, Silo and Harvester
1ebd800
@evgeniysergeev
Remove pips for Frigate, Infantry and Vechicle. Remove unused pips se…
3a2338b 
…quences
@evgeniysergeev
Merge branch 't2' of https://github.com/evgeniysergeev/d2 into t2
c4e294d
@evgeniysergeev
Copy link
Collaborator Author

evgeniysergeev commented Sep 27, 2019 •
edited
Loading

SCP? is that a file ending?

SCREEN.CPS

SCREEN_CPS

phrohdoh
phrohdoh reviewed Sep 27, 2019
View reviewed changes
AUTHORS
@@ -0,0 +1 @@
../d2/mods/d2/AUTHORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is funky.
I suspect you want ./mods/d2/AUTHORS if you're going to put a path in this file.

@evgeniysergeev evgeniysergeev mentioned this pull request Sep 27, 2019
Closed
@abcdefg30
Copy link
Member

Looking at the odd commit display, this PR probably needs a rebase?

@evgeniysergeev
Copy link
Collaborator Author

evgeniysergeev commented Sep 27, 2019 •
edited
Loading

Looking at the odd commit display, this PR probably needs a rebase?

It's hard to maintain this pull request. so Created #148 instead. Closing this PR for now. It will be made after Top bar will be drawn ( #149 ) together with sidebar ( #124 )

@evgeniysergeev evgeniysergeev deleted the t2 branch May 27, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phrohdoh phrohdoh phrohdoh left review comments

@abcdefg30 abcdefg30 Awaiting requested review from abcdefg30

@MustaphaTR MustaphaTR Awaiting requested review from MustaphaTR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgeniysergeev @MustaphaTR @phrohdoh @abcdefg30 @TheRaffy