Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to release-20231010 #193

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Update to release-20231010 #193

merged 11 commits into from
Nov 3, 2023

Conversation

penev92
Copy link
Member

@penev92 penev92 commented Oct 7, 2023 •
edited
Loading

This updates the SDK scripts and the Example mod to the upcoming brand new OpenRA release.

Needs to be updated with the release tag once that is created.

@penev92 penev92 force-pushed the update-to-20231010 branch from ca1d5d4 to 74b263d Compare October 11, 2023 13:37
@penev92 penev92 marked this pull request as ready for review October 11, 2023 13:44
@penev92
Copy link
Member Author

penev92 commented Oct 11, 2023

This should now be good to go.

@PunkPun
Copy link
Member

PunkPun commented Oct 12, 2023

It would be cool to give maps a refresh. To update their MapFormat

@penev92
Copy link
Member Author

penev92 commented Oct 15, 2023

I'll look into the maps update.
Should I copy the observer YAML from one of the base mods?

@PunkPun
Copy link
Member

PunkPun commented Oct 15, 2023 •
edited
Loading

While I don't like copying as it will put on put a maintenance cost, the notion on #20436 is that you should

@penev92 penev92 force-pushed the update-to-20231010 branch from 74b263d to 349cb84 Compare October 15, 2023 18:59
@penev92
Copy link
Member Author

penev92 commented Oct 15, 2023

I added the exact same file that #20436 removed 🤷‍♂️

@PunkPun
Copy link
Member

PunkPun commented Oct 15, 2023

That would be the wrong solution as it was outdated, you should add one of the newer mods, maybe of TS as it's the most simmilar?

@penev92 penev92 force-pushed the update-to-20231010 branch from 349cb84 to e1c0cc7 Compare October 15, 2023 20:54
@penev92
Copy link
Member Author

penev92 commented Oct 15, 2023

Okay, used the TS one. Luckily there were some pretty minor differences.

@penev92
Ran the update rules on the example mod
befef1c 
Running a second time actually fixed a duplucate Filename: on the sequences that the first run created!
@penev92 penev92 force-pushed the update-to-20231010 branch from e1c0cc7 to 3dc877f Compare October 17, 2023 07:18
@penev92
Copy link
Member Author

penev92 commented Oct 17, 2023

Resaved both maps via the map editor in order to update them.
Also (accidentally) rerun the update rules, which fixed a silly result that the first run produced on editor-overlay's sequence.

@penev92 penev92 force-pushed the update-to-20231010 branch from 3dc877f to cde57bd Compare October 17, 2023 12:18
PunkPun
PunkPun reviewed Oct 21, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to watch a replay it crashed with

Exception of type System.IO.InvalidDataException: Cannot find widget with Id HPF_OVERLAY

@penev92
Added an ingame-observer.yaml file
2f73587 
OpenRA PR 20436 removed the common file that none of the default mods use, so adding a copy of the one from TS here.
Removed redundant (and crashing) references to HPF and statistics widgets - the world actor doesn't have the necessary traits because it doesn't need them, so the widgets crash.
@penev92
Fixed translation warnings
3a7eb6b 
By updating game speed settings, copying over translations from `common|languages/rules/en.ftl` for missing translations and defining a translation key for `StartingUnits.ClassName`.
@penev92
Resaved maps to update them
4ad0cbf 
Because of OpenRA PR 19891.
@penev92 penev92 force-pushed the update-to-20231010 branch from cde57bd to 4ad0cbf Compare November 3, 2023 12:05
@penev92
Copy link
Member Author

penev92 commented Nov 3, 2023

Removed a big chunk of the newly-added mods/example/chrome/ingame-observer.yaml that referenced HPF and observer statistics. Those widgets would crash because the World actor is missing traits that honestly it doesn't need in the Example mod, so I think it's best to just simplify everything by removing the redundant yaml.

@penev92 penev92 mentioned this pull request Nov 3, 2023
Closed
@PunkPun PunkPun merged commit 639dbbb into OpenRA:master Nov 3, 2023
3 checks passed
@penev92 penev92 deleted the update-to-20231010 branch November 3, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun left review comments

@Mailaender Mailaender Mailaender left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penev92 @PunkPun @Mailaender