SetterTester and GetterTester improvement #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation. Sometimes when build unit tests for legacy code, you can find bad programming from people that put business logic inside getter/setter. And, since you cannot refactor it, OpenPojo fails. To avoid skipping the entire class because a field, this modification helps it.
validation. Sometimes when build unit tests for legacy code, you can find bad programming from people that put business logic inside getter/setter. And, since you cannot refactor it, OpenPojo fails. To avoid skipping the entire class because a field, this modification helps it.
This was referenced Sep 7, 2016
konrad7d
reviewed
Feb 21, 2017
| public void test() { | ||
| PojoClass personPojo = PojoClassFactory.getPojoClass(Person.class); | ||
|
|
||
| SetterTester setterTester = new SetterTester(); |
There was a problem hiding this comment.
How about supplying skipped fields via constructor?
SetterTester setterTester = new SetterTester(String... skippedFields);
konrad7d
reviewed
Feb 21, 2017
|
Hi all, Why this use full PR isnot merged? |
|
@oshoukry - any thoughts on including something like this into the next release? |
|
See issue 66 for other comments relevant to this enhancement as well as a workaround until this or a similar change makes it into the code base. |
|
Hi @oshoukry , could you please give a statement whether or not this PR will make it to the baseline? So please let us know what to do to enhance OpenPojo. Sincerely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved SetterTester and GetterTester classes which introduces the possibility of jump / skip some fields during the validation class.