Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Makefiles to build libraries on Linux/macOS #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

bucanero
Copy link

This PR updated the lib Makefiles so they work with Open Orbis SDK on Linux and macOS.

Notes:

If required, I can submit a PR to the main repo to add build_rules.mk there.

shifting a negative signed value is undefined ("-1L << 16" in inflate.c)
madler/zlib#183
include for ioctl(...)
@sleirsgoevy
Copy link

... must be copied to ...

What if its installed system-wide and I don't have root?

@bucanero
Copy link
Author

... must be copied to ...

What if its installed system-wide and I don't have root?

Yes, I see your point.
I think that a build_rules.mk should be part of the OpenOrbis repository and be bundled with the installation packages. That way, if you install Open Orbis SDK these generic build rules would be available for any Makefile and any Open Orbis project. I think that would also simplify most OO makefiles a lot, as many steps could be moved to this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants