Fixing version negotiation when using version bitmap #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. Version negotiation is somewhat broken in 0.1, and there's PR #6 in 0.2 that should fix this (however, I didn't have the chance to take a detailed look and test anything in 0.2 yet). I'm a little in doubt about including your fix in master, since it should be fixed in 0.2. It is clearly a bug fix, but it also changes external behavior for 0.1, sort of breaking with assumptions others may have made. Sorry for taking so long to get to this, I haven't had the time to work on libfluid for a long while... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing version bitmaps, OFServer currently sends back whatever version the switch sent to the server, which is incorrect. Instead, it should agree on the highest shared version between the server and the switch, and send this version to the switch.
For example, if the switch supports OF1.0, OF1.3 and OF1.4, and the server supports OF1.0 and OF1.3, the previous method would agree on OF1.4. Now, it correctly agrees on OF1.3.
This fix won't affect the non-bitmap version negotiation.