Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B #6759: finalize the SG rules on sg rule error #6760

Closed
wants to merge 2 commits into from
Closed

B #6759: finalize the SG rules on sg rule error #6760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18477a
B #6759: finalise the SG rules on sg rule error
atodorov-storpool Oct 22, 2024
d1e4734
B #6759: finalise the SG rules on sg rule error (v2)
atodorov-storpool Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/vnm_mad/remotes/lib/sg_driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def activate(do_all = false)
end

# Process the rules for each NIC
sg_error = 0
process do |nic|
next if attach_nic_id && attach_nic_id != nic[:nic_id]

Expand All @@ -124,9 +125,8 @@ def activate(do_all = false)
sg.process_rules
sg.run!
rescue StandardError => e
unlock
deactivate(do_all)
raise e
sg_error = e
break
end
end

Expand All @@ -142,6 +142,10 @@ def activate(do_all = false)

unlock

unless sg_error == 0
raise sg_error
end

0
end

Expand Down