Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Co-authored-by: Tino Vázquez <[email protected]>

These parameters were fixed: * schedid in onebackupjob * execid in onehook * snapshot_id in oneimage * nicid, pciid, sched_id and sgid in onevm * nicid in onevrouter * serverid in onezone For all those parameters the string used as ID: * if possible the name is converted is converted to int ID * fails if the resource doesn't have name (cherry picked from commit f5b2a173607e2f045ce3de95755828cef4bcca5b)

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

(cherry picked from commit ec16b5367656b0496e30ba84bb3ae98edd6c86bc)

Signed-off-by: Guillermo Ramos <[email protected]>

(cherry picked from commit 2802647b5841865c43d7bb8c2240049f66bb23c7)

* Fix virtual network not ready tests * Adds exponential backoff helper and corrects hook test * Fixes GOCA context and VM test Signed-off-by: Jaime <[email protected]> Signed-off-by: Aleix Ramírez <[email protected]> (cherry picked from commit f091804)

Signed-off-by: Jaime <[email protected]>

* M #-: Replace raw pointers with references/smart pointers. - Change PoolSQL::allocate method's signature to accept reference instead of pointer and fix all method calls. - Remove some of the error-handling goto, to be able initialize some variables during declaration. Signed-off-by: Valentyn Bohdan <[email protected]>

* Remove vm_import table from DB * Remove imported vms actions * Fix fsck for image and network * onedb fsck fix running_vms only for non-backup images

Co-authored-by: Tino Vázquez <[email protected]>

* CGROUPS_VERSION, FIRMWARE, FIRMWARE_SECURE and CPU_MODEL/FEATURES can be overriden by Cluster and Host * Fix attribute name in attach_disk

+ fix attribute name in kvmrc

* Removes checkbox to b64 encode start script * Fixes template filtering to not strip the start script from the Context section Signed-off-by: Victor Hansson <[email protected]>

- Now are named local. SSH drivers will be distributed for running VMs that use the SSH drivers. - The new drivers optimize Qcow2 operations in the same way as the shared TM driver, including: - thin provisioning, when available a cow copy is made - Qcow2 snapshots for the snapshot operations - Some operations has been improved code-wise - It should be a drop-in replacement for ssh - New drivers are written in Ruby to accommodate future improvements - By default new datastores will use "local" instead of "ssh" co-authored-by: Ruben S. Montero <[email protected]>

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Ruben S. Montero <[email protected]>

Signed-off-by: Guillermo Ramos <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

This commit solves the problem by improving the overflow in integer types Signed-off-by: Valentyn Bohdan <[email protected]>

Signed-off-by: Valentyn Bohdan <[email protected]> Co-authored-by: Pavel Czerny <[email protected]>

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

jloboescalona2 and others added 11 commits November 4, 2024 18:17

F #6769: Removed Provision/Provider app (#3283)

f5407c2

Co-authored-by: Tino Vázquez <[email protected]>

F #6770: Downgrade unf gem (< 0.2.0) for RedHat8 and AlmaLinux8 (#3286)

d29681e

F #6769: fix first render provider/provision (#3288)

c6e611e

B #6730: Search admin users in the right array (#3289)

e2c54b1

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

F #6769: Fix provider create form (#3291)

0c1bf22

M #-: Clarify live migration storage limitation

4f4a6d5

F #6790: Fix Hugepages bug in Sunstone (#3295)

be0edd0

(cherry picked from commit ec16b5367656b0496e30ba84bb3ae98edd6c86bc)

Fix #-: DS ceph export: use CEPH_KEY (#3296)

4426443

Signed-off-by: Guillermo Ramos <[email protected]>

F #6790: Fix for Hugepages in RSunstone monitoring (#3299)

bb029bb

(cherry picked from commit 2802647b5841865c43d7bb8c2240049f66bb23c7)

rsmontero force-pushed the master branch from f091804 to 9d5da2d Compare November 20, 2024 16:38

jaimecb and others added 18 commits November 20, 2024 18:21

F #6782 Extend GOCA OSVec struct (#3301)

bb65c22

Signed-off-by: Jaime <[email protected]>

B #-: Fix javadoc reference (#3292)

a065575

B #6784: Remove unneeded/non-existing python dep (#3293)

f4616d0

F #6723: Remove onehost importvm (#3231)

fa73142

* Remove vm_import table from DB * Remove imported vms actions * Fix fsck for image and network * onedb fsck fix running_vms only for non-backup images

F #6599: External VNC management (#3304)

13b6f4a

Co-authored-by: Tino Vázquez <[email protected]>

B #6548: Fix kvm attributes

fb715c3

* CGROUPS_VERSION, FIRMWARE, FIRMWARE_SECURE and CPU_MODEL/FEATURES can be overriden by Cluster and Host * Fix attribute name in attach_disk

B #6548: Updtate vmm_exec_kvm.conf description

0357ffb

+ fix attribute name in kvmrc

B #6793: Fix crash of onedb fsck on MarketPlaceApp (#3302)

130713b

M #-: Always b64 encode start script (#3305)

6254ad8

* Removes checkbox to b64 encode start script * Fixes template filtering to not strip the start script from the Context section Signed-off-by: Victor Hansson <[email protected]>

L #-: Fix rubocop errors

7bc581e

F #5853: Replace ssh for local mode in datastores (#3306)

f5637b5

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Ruben S. Montero <[email protected]>

F #5853: fix rhel8 (Ruby<2.7) (#3308)

38e28dd

Signed-off-by: Guillermo Ramos <[email protected]>

F #5853: Add local TM_MAD to defaults (#3309)

987bf1a

B #-: Fixes null check for appConfig (#3310)

ee25fdc

Signed-off-by: Victor Hansson <[email protected]>

B #6750: Fix iotune attributes not being passed to VM

c5ef443

This commit solves the problem by improving the overflow in integer types Signed-off-by: Valentyn Bohdan <[email protected]>

F #6771: Replace deprecated OpenSSL function calls. (#3297)

478c156

Signed-off-by: Valentyn Bohdan <[email protected]> Co-authored-by: Pavel Czerny <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese commented Nov 29, 2021 •

edited

Loading

tinova Apr 25, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading