Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reimplement beam visualization #1240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bpopeters
Copy link
Contributor

This pull request reimplements dumping a json file representing the beam, as was requested in #719. It's not perfect, however:

  1. Beam visualization only implemented with the slow translation path. Not such a big problem because you're unlikely to want to visualize more than a few sentences.
  2. It's only implemented with batch_size == 1. With larger batch sizes, the beam file generates but in scrambled order and I'm not sure why. As above, not such a big deal.
  3. Occasionally I'm getting indexing errors when running generate_beam_viz.py. It's not clear to me where these errors originate and whether they are the result of incorrectly-formatted data in the json file or a bug in generate_beam_viz.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant