Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: armv7 and android static omp support #1600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ebraraktas
Copy link
Contributor

This PR adds armv7 support:

  • Implement slower generic versions of div, mul_add, reduce_add, reduce_max.
  • Rename CT2_ARM64_BUILD as CT2_ARM_BUILD

Tested this on Galaxy S21 with library built for armv7, all tests passed.

In addition, modified CMakeLists.txt to link with static omp for Android. Before this, libomp.so must have been shipped with this library.

@ebraraktas
Copy link
Contributor Author

@minhthuc2502 I rebased this PR, too. And CI error seems to be unrelated to the imlementation (no space left): https://github.com/OpenNMT/CTranslate2/actions/runs/10285902385/job/28465295705#step:3:1084

@ebraraktas ebraraktas force-pushed the build/armv7-android-static-omp branch from 91bff45 to 953cd06 Compare August 12, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant