Remove not needed validation on privacy_id_extractor #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
changed the title
| @@ -420,10 +420,6 @@ def _check_aggregate_params(self, | |||
| if check_data_extractors: | |||
| _check_data_extractors(data_extractors) | |||
| if params.contribution_bounds_already_enforced: | |||
| if data_extractors.privacy_id_extractor: | |||
There was a problem hiding this comment.
Would it be possible to log a warning? Clients might have an incorrect configuration in this case.
There was a problem hiding this comment.
I'd say that having privacy_id_extractor is a correct configuration, even if no contribution bounding happens, e.g. in principle it would allow to compute PRIVACY_ID_COUNT per partition. So let's keep w/o warnings.
miracvbasaran
approved these changes
Oct 25, 2023
dvadym
commented
Oct 25, 2023
| @@ -420,10 +420,6 @@ def _check_aggregate_params(self, | |||
| if check_data_extractors: | |||
| _check_data_extractors(data_extractors) | |||
| if params.contribution_bounds_already_enforced: | |||
| if data_extractors.privacy_id_extractor: | |||
There was a problem hiding this comment.
I'd say that having privacy_id_extractor is a correct configuration, even if no contribution bounding happens, e.g. in principle it would allow to compute PRIVACY_ID_COUNT per partition. So let's keep w/o warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
contribution_bounds_already_enforced = Truethen PipelineDP does no contribution bounding. As a privacy id is not needed. The current validation requiresprivacy_id_extractorto be None, but there is no problem if privacy id extractor is set up. But it's pretty confusing for users whyprivacy_id_extractorhas to beNone. Let's drop this validation for simplicity