Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python workspace #190

Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix python workspace #190

merged 6 commits into from
Jan 17, 2024

Conversation

s0l0ist
Copy link
Contributor

@s0l0ist s0l0ist commented Jan 16, 2024

Description

fixes #189

NOTE: This requires a default python of Python 3.10 - 3.8 to be installed. Otherwise, one of the Bazel dependencies breaks. Further investigation is needed, but this should be a good enough work around.

Affected Dependencies

  • The ubuntu-latest image in the Github actions changed the version of Python that we were relying on. I've updated the CI/CD workflows to use Python 3.10 (arbitrarily) which is compatible with Bazel.
  • I've also updated a few Golang and Python Bazel dependencies

How has this been tested?

  • I can build the PSI repo locally
  • I created a new test workspace and followed the updated workspace guide in the Readme. i.e. running bazelisk build //... on a shell project that imports the PSI workspace works (tested with python 3.10)

Checklist

@s0l0ist s0l0ist marked this pull request as ready for review January 17, 2024 00:21
@s0l0ist s0l0ist added Type: Bug 🐛 Some functionality not working in the codebase as intended dependencies Pull requests that update a dependency file labels Jan 17, 2024
@s0l0ist s0l0ist merged commit 09a59f9 into master Jan 17, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nangelou-requirements-fix branch January 17, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Bug 🐛 Some functionality not working in the codebase as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant