Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support s3 bench build during client build #41

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Support s3 bench build during client build #41

merged 10 commits into from
Nov 10, 2023

Conversation

velomatt
Copy link
Contributor

  • update docker image to include golang for s3bench build
  • update commit IDs for submodules

@velomatt velomatt requested a review from a team as a code owner November 10, 2023 22:43
snubatreus
snubatreus approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit 65d3104 into master Nov 10, 2023
1 check passed
@velomatt velomatt deleted the support-s3-bench-build-during-client-build branch November 10, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snubatreus snubatreus snubatreus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velomatt @snubatreus