(don't review) testing to fix non-fips ltpa fat #30536

jimmy1wu · 2025-01-10T23:14:19Z

** don't review this one pls **

Rename generate3DESKey method to generateSharedKey

Fips work

…Swork

add common crypto to ssl feature

Fip swork

…PSwork

….xml before server start adding AEADBadTagException to AllowedFFDC list for tests which expect BadPaddingException using jvm.options so that mbean invocations will use proper jvm parameters

…PSwork

updating server xml's with appropriate passwords, renaming serverFIPS…

…Swork

jimmy1wu · 2025-01-10T23:15:04Z

!build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
git.clone.checkout.branch=FIPSwork_01072025
git.clone.repository.username=JimmyWu

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-10T23:22:47Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
70 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-10T23:22:48Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

jimmy1wu · 2025-01-11T16:04:38Z

!build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
git.clone.checkout.branch=FIPSwork_01072025
git.clone.repository.username=JimmyWu

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-11T16:12:11Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
70 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-11T16:12:12Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

jimmy1wu · 2025-01-14T01:03:25Z

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
git.clone.checkout.branch=FIPSwork_01072025
git.clone.repository.username=JimmyWu

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-14T01:11:01Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
70 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-14T01:11:02Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

mshah0722 and others added 30 commits September 13, 2024 17:38

Supporting FIPS work

6f1eb56

Minor bug fixes

7efb1ad

Minor changes

5f4264e

Use the common crypto bundle

9530112

Create the Provider class

67ca4cb

clean up

3b6d858

Adding support to client and server for java 17

a671f21

Rename generate3DESKey method to generateSharedKey

a90e9bf

Merge branch 'OpenLiberty:integration' into FIPSwork

85c2c57

Fixing some test bugs

a4fa8ba

Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into HEAD

e1cbd56

Merge pull request OpenLiberty#1 from utle/FIPSwork

cf9acf4

Rename generate3DESKey method to generateSharedKey

Minor bugs

d65866e

Added debug msgs

c04b999

SSL to use crypto common code

2123cf5

Merge pull request OpenLiberty#2 from utle/FIPSwork

af2fe51

Fips work

Merge branch 'OpenLiberty:integration' into FIPSwork

7df6665

Restrict TLS versions for FIPS

cde667d

Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…

2f16885

…Swork

Restrict TLS versions for FIPS

dea7785

Handle Semeru

ebaadc1

Merging Ut's code

0d67b38

add common crypto to ssl feature

1692ecf

Merge pull request OpenLiberty#4 from utle/FIPSwork

d15c6d4

add common crypto to ssl feature

enable openJCEPlusFips

ed707fa

clean up

6186795

Merge pull request OpenLiberty#5 from utle/FIPSwork

11f08a2

Fip swork

enable openJCEPlusFips

3bc4615

Merge remote-tracking branch 'ut_branch/FIPSwork' into FIPSwork

3bcc438

Merge branch 'OpenLiberty:integration' into FIPSwork

a1994c1

utle and others added 13 commits December 13, 2024 16:02

adding more check

dd20353

Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…

48badd8

…PSwork

adding more check

73c9080

Merge branch 'FIPSwork' of github.com:utle/open-liberty into FIPSwork

4569d99

Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…

b66c91c

…PSwork

updating server xml's with appropriate passwords, renaming serverFIPS…

adda4f7

….xml before server start adding AEADBadTagException to AllowedFFDC list for tests which expect BadPaddingException using jvm.options so that mbean invocations will use proper jvm parameters

wip

15c328a

Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…

c3d2bc5

…PSwork

Merge pull request OpenLiberty#18 from jacobwdv/JD_LTPAKeyTest

f9d5812

updating server xml's with appropriate passwords, renaming serverFIPS…

Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…

3253d05

…Swork

Merge remote-tracking branch 'origin/release' into FIPSwork_01072025

3221f8e

Handle FIPS 140-2 and 140-3 separated to keep the current behavior

4689e3d

Merge remote-tracking branch 'ut_fork/FIPSwork' into FIPSwork_01072025

58df82d

jimmy1wu marked this pull request as draft January 10, 2025 23:14

jimmy1wu changed the title ~~testing to fix non-fips ltpa fat~~ (don't review) testing to fix non-fips ltpa fat Jan 10, 2025

remove duplicate ltpa config in nonFIPS case

7b9dbeb

jimmy1wu force-pushed the jimmy-test branch from 8bcb6a5 to 7b9dbeb Compare January 11, 2025 16:03

LibbyBot added the CLA Signed label Jan 11, 2025

jimmy1wu closed this Jan 13, 2025

jimmy1wu reopened this Jan 14, 2025

add missing configuredValidation1.keys for ltpa fat if fips is enabled

0dbf926

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(don't review) testing to fix non-fips ltpa fat #30536

(don't review) testing to fix non-fips ltpa fat #30536

jimmy1wu commented Jan 10, 2025 •

edited

Loading

jimmy1wu commented Jan 10, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 10, 2025

LibbyBot commented Jan 10, 2025

jimmy1wu commented Jan 11, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 11, 2025

LibbyBot commented Jan 11, 2025

jimmy1wu commented Jan 14, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 14, 2025

LibbyBot commented Jan 14, 2025

(don't review) testing to fix non-fips ltpa fat #30536

Are you sure you want to change the base?

(don't review) testing to fix non-fips ltpa fat #30536

Conversation

jimmy1wu commented Jan 10, 2025 • edited Loading

jimmy1wu commented Jan 10, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 10, 2025

Code analysis and actions

LibbyBot commented Jan 10, 2025

jimmy1wu commented Jan 11, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 11, 2025

Code analysis and actions

LibbyBot commented Jan 11, 2025

jimmy1wu commented Jan 14, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 14, 2025

Code analysis and actions

LibbyBot commented Jan 14, 2025

jimmy1wu commented Jan 10, 2025 •

edited

Loading

jimmy1wu commented Jan 10, 2025 •

edited by LibbyBot

Loading

jimmy1wu commented Jan 11, 2025 •

edited by LibbyBot

Loading

jimmy1wu commented Jan 14, 2025 •

edited by LibbyBot

Loading