Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detect-secrets scanner and false-positives #29759

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

mbroz2
Copy link
Member

@mbroz2 mbroz2 commented Oct 1, 2024

This PR is to update how we scan using detect-secrets and to address the resulting false-positives.

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 2, 2024

The remaining 328 items will be worked through by the security team.

@mbroz2 mbroz2 self-assigned this Oct 3, 2024
@mbroz2
Copy link
Member Author

mbroz2 commented Oct 4, 2024

#build

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

We could not perform your request. We allow builds for authorized users and trusted code only.

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 4, 2024

!build

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

We could not perform your request. We allow builds for authorized users and trusted code only.

1 similar comment
@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

We could not perform your request. We allow builds for authorized users and trusted code only.

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 4, 2024

#libby

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3lNNgIJfEe-TieZHY4j0Qw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Oct 5, 2024

The build mbroz2-29759-20241004-1555
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3lNNgIJfEe-TieZHY4j0Qw
completed successfully!

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 5, 2024

Green build (though the code changes should have zero impact on anything that currently occurs as part of the build)

@mbroz2 mbroz2 merged commit 1be8372 into integration Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants