Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CDI.current() in threads that were not created by Jakarta Concurrency. #29741

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Support CDI.current() in threads that were not created by Jakarta Concurrency. #29741

merged 4 commits into from
Oct 4, 2024

Conversation

benjamin-confino
Copy link
Member

@benjamin-confino benjamin-confino commented Sep 27, 2024 •
edited
Loading

zero migration - this is only going to occur as a fallback method, if we reach the new code it means the old code wasn't working.

Resolves #29493

@benjamin-confino
Copy link
Member Author

I already spoke with David Zavala about the classloading change, he was ok with it but wanted to speak to his wider team before approving.

tjwatson
tjwatson previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class loading service changes and usage look good to me. Should get another review on the other CDI details.

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=61bd9125-647f-4b70-846a-bdbae19c5599

Target locations of links might be accessible only to IBM employees.

Emily-Jiang
Emily-Jiang previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ltxHwH0CEe-PXJdaQbhamQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=61bd9125-647f-4b70-846a-bdbae19c5599 has errors/failures.

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3e051344-3fad-462c-ae0a-fbd1e34848af

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Oy2mYH1eEe-PXJdaQbhamQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build benjamin-confino-29741-20240927-1307
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ltxHwH0CEe-PXJdaQbhamQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_ltxHwH0CEe-PXJdaQbhamQ

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3e051344-3fad-462c-ae0a-fbd1e34848af has errors/failures.

@LibbyBot
Copy link

The build benjamin-confino-29741-20240928-0003
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Oy2mYH1eEe-PXJdaQbhamQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_Oy2mYH1eEe-PXJdaQbhamQ

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6ec4d3e6-b4c0-4068-93e1-7378dd05d809

Target locations of links might be accessible only to IBM employees.

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=06cc13f4-c541-4289-8ed9-78b890d664c5

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lqd1QICpEe-TieZHY4j0Qw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nHCqgIC1Ee-TieZHY4j0Qw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=06cc13f4-c541-4289-8ed9-78b890d664c5 has errors/failures.

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6ec4d3e6-b4c0-4068-93e1-7378dd05d809 has errors/failures.

@LibbyBot
Copy link

LibbyBot commented Oct 3, 2024

The build benjamin-confino-29741-20241002-0440
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lqd1QICpEe-TieZHY4j0Qw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_lqd1QICpEe-TieZHY4j0Qw

@LibbyBot
Copy link

LibbyBot commented Oct 3, 2024

The build benjamin-confino-29741-20241002-0606
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nHCqgIC1Ee-TieZHY4j0Qw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_nHCqgIC1Ee-TieZHY4j0Qw

abutch3r
abutch3r approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@abutch3r abutch3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

All the CDI tests that failed previously have run successfully in both CI and RTC builds and there is no correlation within the tests across the platforms to say this has broken anything

@benjamin-confino
Copy link
Member Author

#libby

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 9 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 5 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@benjamin-confino benjamin-confino merged commit c9c479f into OpenLiberty:integration Oct 4, 2024
2 of 3 checks passed
@benjamin-confino benjamin-confino deleted the cdi-current-threading branch October 4, 2024 09:30
@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

The build benjamin-confino-29741-20241003-2259
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__sa8wIHREe-TieZHY4j0Qw
completed successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutch3r abutch3r abutch3r approved these changes

@Emily-Jiang Emily-Jiang Emily-Jiang left review comments

@tjwatson tjwatson tjwatson left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDI does not use the TCCL for finding the correct app when calling CDI.current()
5 participants
@benjamin-confino @LibbyBot @tjwatson @Emily-Jiang @abutch3r