Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading Hibernate validator from 7 to 9 #29668

Merged
merged 31 commits into from
Nov 13, 2024
Merged

Upgrading Hibernate validator from 7 to 9 #29668

merged 31 commits into from
Nov 13, 2024

Commits on Oct 28, 2024

  1. Initial commit for upgrading Hibernate validator to 9

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ebea931 View commit details
    Browse the repository at this point in the history

  2. More changes for upgrading hibernate validator

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    815b5c9 View commit details
    Browse the repository at this point in the history

  3. changes in com.ibm.ws.beanvalidation.v20.cdi project

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f3d9ed2 View commit details
    Browse the repository at this point in the history

  4. Hibernate Validator 9.0+ package location for InjectingConstraintVali… 

    …datorFactory dependency correction
    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6a56d83 View commit details
    Browse the repository at this point in the history

  5. update dev/com.ibm.ws.beanvalidation.v20.cdi/bnd.bnd

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1478923 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. update org.hibernate.validator.cdi.spi version in bnd

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    af8971f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. review comments changes

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d58c2d3 View commit details
    Browse the repository at this point in the history

  2. Update dev/io.openliberty.org.hibernate.validator.9.0/bnd.overrides 

    Co-authored-by: Mark Swatosh <[email protected]>
    @gauthamkrishnanibm @mswatosh
    gauthamkrishnanibm and mswatosh authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a2f76ca View commit details
    Browse the repository at this point in the history

  3. Update dev/com.ibm.websphere.appserver.features/visibility/auto/io.op… 

    …enliberty.beanValidationCDI-3.1.feature

Co-authored-by: Mark Swatosh <[email protected]>
    @gauthamkrishnanibm @mswatosh
    gauthamkrishnanibm and mswatosh authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8bd7685 View commit details
    Browse the repository at this point in the history

  4. Update dev/com.ibm.ws.beanvalidation.v20.cdi/src/com/ibm/ws/beanvalid… 

    …ation/v20/cdi/internal/BvalManagedObjectBuilderImpl.java

Co-authored-by: Mark Swatosh <[email protected]>
    @gauthamkrishnanibm @mswatosh
    gauthamkrishnanibm and mswatosh authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bfd1556 View commit details
    Browse the repository at this point in the history

  5. Update dev/io.openliberty.org.hibernate.validator.9.0/bnd.overrides 

    Co-authored-by: Mark Swatosh <[email protected]>
    @gauthamkrishnanibm @mswatosh
    gauthamkrishnanibm and mswatosh authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1fd15c0 View commit details
    Browse the repository at this point in the history

  6. Update dev/io.openliberty.org.hibernate.validator.9.0/bnd.bnd 

    Co-authored-by: Mark Swatosh <[email protected]>
    @gauthamkrishnanibm @mswatosh
    gauthamkrishnanibm and mswatosh authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    93e96f4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'integration' into upgrade-hv

    @gauthamkrishnanibm
    gauthamkrishnanibm authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1a3c8a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. review comments correction

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d498a92 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. fixing code review comments

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ed1471e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. changes for Jared's code review comments

    @gauthamkrishnanibm
    gauthamkrishnanibm committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8954632 View commit details
    Browse the repository at this point in the history

  2. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee9and10.pr… 

    …operties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7699d76 View commit details
    Browse the repository at this point in the history

  3. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee9and10.pr… 

    …operties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ce2c27a View commit details
    Browse the repository at this point in the history

  4. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee9.properties 

    Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f3db3ed View commit details
    Browse the repository at this point in the history

  5. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee9.properties 

    Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5fce1bb View commit details
    Browse the repository at this point in the history

  6. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee10.proper… 

    …ties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a625145 View commit details
    Browse the repository at this point in the history

  7. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee10.proper… 

    …ties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    09cf99a View commit details
    Browse the repository at this point in the history

  8. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee11.proper… 

    …ties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ad4997b View commit details
    Browse the repository at this point in the history

  9. Update dev/wlp-jakartaee-transform/rules/jakarta-versions-ee11.proper… 

    …ties

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c23210f View commit details
    Browse the repository at this point in the history

  10. Update dev/io.openliberty.org.hibernate.validator.9.0/.classpath 

    Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c6162dd View commit details
    Browse the repository at this point in the history

  11. Update dev/com.ibm.websphere.appserver.features/visibility/auto/io.op… 

    …enliberty.beanValidationCDI-3.1.feature

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6879227 View commit details
    Browse the repository at this point in the history

  12. Update dev/com.ibm.websphere.appserver.features/visibility/auto/io.op… 

    …enliberty.beanValidationCDI-3.0.feature

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    96786b4 View commit details
    Browse the repository at this point in the history

  13. Update dev/com.ibm.websphere.appserver.features/visibility/auto/io.op… 

    …enliberty.beanValidationCDI-3.0.feature

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1b60bc1 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update dev/io.openliberty.org.hibernate.validator.9.0/resources/META-… 

    …INF/beans.xml

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    15e4656 View commit details
    Browse the repository at this point in the history

  2. Update dev/io.openliberty.org.hibernate.validator.cdi.9.0/resources/M… 

    …ETA-INF/beans.xml

Co-authored-by: Jared Anderson <[email protected]>
    @gauthamkrishnanibm @jhanders34
    gauthamkrishnanibm and jhanders34 authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f8066c4 View commit details
    Browse the repository at this point in the history

  3. some cleaning up as suggested in code review 

    updating the injectValidatorFactoryResources method to take a RuntimeVersion argument and passing that argument to createManagedConstraintValidatorFactory and just use it instead of setting it again in BvalManagedObjectBuilderImpl
    @gauthamkrishnanibm
    gauthamkrishnanibm committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c56b32f View commit details
    Browse the repository at this point in the history