Add initial gradle support #154
Conversation
Signed-off-by: Edward Mezarina <[email protected]>
|
|
||
| # Copy application source and build data. | ||
| COPY --chown=1001:0 ./. /work/outer-loop-app/tmp/ | ||
| RUN cp -r /work/outer-loop-app/tmp/src /work/outer-loop-app/.; \ |
There was a problem hiding this comment.
IIUC, the reason this looks so complicated, with the gradle globbing, is that we want to avoid copying someones target/build dir into the docker build container. Should we just do a regex copy or find piped into a copy somehow or some other tool to copy "everything but the build dir"?
The same comment applies to maven, where we copy /src and pom.xml but not say /data that possibly someone might want.
There was a problem hiding this comment.
I'm more concerned with the "contract" than the caching. For mvn it is easy to understand that we COPY in /src and /pom.xml. What's our rationale for including these gradle-related globs? What parts are we gathering?
Note we could choose to say: "copy everything and you should be using .dockerignore to filter it out". Maybe our starter and least should have a .dockerignore.
mezarin
force-pushed
the
addGradleArtifacts
branch
7 times, most recently
from
51d83a7
to
ff194f5
Compare
mezarin
force-pushed
the
addGradleArtifacts
branch
from
ff194f5
to
b457f9f
Compare
Signed-off-by: Edward Mezarina <[email protected]>
mezarin
force-pushed
the
addGradleArtifacts
branch
from
b457f9f
to
4c52479
Compare
This PR adds gradle artifacts and fixes other issues (outdated links, test bugs, etc).