Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review copying all files vs. selective copy in outer loop ; Also add mvn (/target) and gradle (/build) .dockerignore for samples, starter projects #156

Open
scottkurz opened this issue Jul 21, 2021 · 0 comments

Comments

@scottkurz
Copy link
Member

scottkurz commented Jul 21, 2021

E.g. in the outer loop maven build we're just copying src and pom.xml which is everything standard but what if a user had a 'data' dir or something non-standard? (You'd think that'd be likely just for test but possibly not).

It would be a waste to copy a full /target in but this could be handled via .dockerignore , which we should add anyway.

@scottkurz scottkurz changed the title Add mvn (/target) and gradle (/build) .dockerignore for samples, starter projects Review copying all files vs. selective copy in outer loop ; Also add mvn (/target) and gradle (/build) .dockerignore for samples, starter projects Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant