Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect install config changes during dev mode #1796

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Detect install config changes during dev mode #1796

merged 3 commits into from
Feb 22, 2024

Conversation

cherylking
Copy link
Member

Fixes #1794
Fixes #1795

Equivalent PR to Gradle changes in OpenLiberty/ci.gradle#880

@cherylking
Copy link
Member Author

cherylking commented Feb 19, 2024 •
edited
Loading

This is what the updated error looks like:

Screenshot 2024-02-21 at 9 48 29 AM

@cherylking
Copy link
Member Author

After discussing at a design issues call today, decided to not say the clean is required when restarting dev mode in this case. Our maven plugin can detect when Liberty needs to be reinstalled even when the target installation dir is the same. Our gradle plugin does not have the same capability currently.

@cherylking cherylking merged commit 47d2619 into OpenLiberty:main Feb 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevCraw TrevCraw TrevCraw approved these changes

@scottkurz scottkurz Awaiting requested review from scottkurz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cherylking @TrevCraw