Add late prop resolution for Liberty configuration specified by Maven props #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the documentation I plan to add for this.
This will go at the end of the |
dshimo
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1705 @bmarwell
Question: Do we only need to resolve the
@{xxx}properties that are referenced in Maven properties? Or do we also need to handle them in the configuration parameters for the plugin (such as thejvmOptionsparameter)?Answer: Yes, we should handle them in other config parameters for consistency. I have implemented the behavior for the
jvmOptionsand thebootstrapPropertiesin this PR.Also, I presume we do not need to look for and resolve these types of references in config files specified by other parameters such as
jvmOptionsFile. Correct me if I am wrong.Answer: We should not look for / resolve these references in config files other than pom.xml.