Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile with editable fields #17

Merged
merged 38 commits into from
Feb 14, 2024
Merged

Conversation

SAISURYAtalla
Copy link
Contributor

@SAISURYAtalla SAISURYAtalla commented Jan 31, 2024

Pull Request: User Profile Integration and Editable Features

Description

This pull request enhances the Smart Insti App by introducing a user profile feature where a user can display his personal information along with his skills , Achievements . The user profile includes editable fields for description , skills section and achievements.

Features

Displays all the information namely name , id, email , branch , graduation year , roles , about , skills as pie charts , and achievements as cards .

How to Test

  1. Launch the Smart Insti App.
  2. Navigate to the user profile screen by tapping on the user icon.
  3. Explore the various sections of the user profile , along with the edit screen by tapping the edit icon on the top right.

Screenshots

user profile
edit_profile
home

Requesting review!
@henilp105

@SAISURYAtalla SAISURYAtalla marked this pull request as draft February 1, 2024 04:21
@SAISURYAtalla SAISURYAtalla changed the title user profile with admin screens integration User profile with editable fields Feb 4, 2024
@SAISURYAtalla SAISURYAtalla marked this pull request as ready for review February 4, 2024 20:46
Copy link
Collaborator

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SAISURYAtalla, please clean up the redundant code there is alot of redundant code.

frontend/lib/screens/home.dart Outdated Show resolved Hide resolved
frontend/lib/models/student2.dart Outdated Show resolved Hide resolved
@SAISURYAtalla
Copy link
Contributor Author

The changes requested have been made in the latest commit .

Kindly review @henilp105

Copy link
Collaborator

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SAISURYAtalla , Remove redundant code.

frontend/lib/constants/dummy_entries.dart Show resolved Hide resolved
frontend/lib/routes/routes.dart Outdated Show resolved Hide resolved
frontend/lib/routes/routes.dart Outdated Show resolved Hide resolved
@henilp105
Copy link
Collaborator

@SAISURYAtalla resolve conflicts.

@SAISURYAtalla
Copy link
Contributor Author

@SAISURYAtalla resolve conflicts.

On it .

@SAISURYAtalla
Copy link
Contributor Author

all conflicts resolved and profile updated along with edit profile and also integrated with auth and remaining PR's

as you can see , the details of the logged in user is only being displayed(which is mine )
Screenshot 2024-02-14 162203
Screenshot 2024-02-14 162216
Screenshot 2024-02-14 162225

Requesting re-review @henilp105 @Aditya062003

@henilp105 henilp105 merged commit d42b9bf into OpenLake:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants