Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refracting Frontend Code - Milestone 2 FOSS (Overflow 2024) #109

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refracting Frontend Code - Milestone 2 FOSS (Overflow 2024) #109

wants to merge 9 commits into from
+4,486 −5,170

Conversation

jaiakash
Copy link
Contributor

@jaiakash jaiakash commented Jan 26, 2024 •
edited
Loading

Purpose ✨

This PR refractor the codebase by

Mentions 👀

@DevilsAutumn @Rounak2001

Developer's checklist 📃

  • Followed the coding guidelines.
  • Properly commented the code.
  • No print statements in the code.
  • All the functionalities are working properly.
  • Changes made are not breaking any other part of the project.
  • No UI/UX issues are present.
  • Followed the PR guidelines

@jaiakash jaiakash changed the title Refracting Code - Milestone Overflow 2024 Refracting Frontend Code - Milestone 2 FOSS (Overflow 2024) Jan 26, 2024
jaiakash
jaiakash commented Jan 26, 2024
View reviewed changes
Copy link
Contributor Author

@jaiakash jaiakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • .env variable for backend
  • moves images to assets folder for better readibility.

@DevilsAutumn
Copy link
Contributor

was this branch created from jaiakash:precommit-hook branch ?

@jaiakash
Copy link
Contributor Author

was this branch created from jaiakash:precommit-hook branch ?

Nope, I created it from the main branch. That branch has issues which I wish to discuss in meet.

jaiakash
jaiakash commented Jan 28, 2024
View reviewed changes
Copy link
Contributor Author

@jaiakash jaiakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • .env file
  • Separating the styles into module CSS file
  • Upgrading/fixing old libraries

@jaiakash jaiakash marked this pull request as ready for review January 28, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the tab title to be LeaderBoard Pro instead of React App
2 participants
@jaiakash @DevilsAutumn