Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLMIS-7989: Added Facility Import & Quick performance improvements #125

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

pwargulak
Copy link
Contributor

Added import for entities:

  • facility
  • supportedProgram

Introduced performance improvements for the import:

  • batching on hibernate and PostgreSQL level - for the whole service
  • custom batching - import parts of the file in parallel
  • custom cache for imports (load up all references needed during the import)

Known issues:

  1. Single batch fail is reported as import failure, but doesn't break other batches - those which succeeded are imported
  2. Error reporting/handling needs more work
  3. It is still synchronous to HTTP request, limited to 60s timeout (by default config)

Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@pwargulak pwargulak merged commit 09b0670 into master Oct 17, 2024
2 of 3 checks passed
@pwargulak pwargulak deleted the OLMIS-7989 branch October 17, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant