Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VTN-to-VEN Reports #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gthole
Copy link

@gthole gthole commented Nov 14, 2024

Allow clients to implement VTN-to-VEN reports with poll callback handlers.

Add callback handlers for oadrRegisterReport and oadrUpdateReport Poll messages.

Notes:

  • oadrRegisterReport will still return an oadrRegisteredReport with no requested reports as before, so there is no change to that behavior unless a VEN client adds a handler.
  • oadrUpdateReport previously would crash the client since it would attempt to call an _on_report method that does not exist on the Client class. Now it will return an oadrUpdatedReport to the VTN and call a handler.

Many thanks for this excellent project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant