Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with cryptography >= 42.0.0 #714

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kajinamit
Copy link
Contributor

The load_der_public_key method and the load_pem_private_key method were removed from Backend class in cryptography 42.0.0[1].

Closes #713

[1] pyca/cryptography@41daf2d

@noonedeadpunk
Copy link

@arp102 hey! Can you kindly check on this one? It would be pretty much appreciated if this compatibility issue could be solved, as it's pretty much a pita right now (and a new release to be cut?:))

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (cae5747) to head (de30604).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files          79       79              
  Lines       17492    17490       -2     
==========================================
- Hits        16903    16901       -2     
  Misses        589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arp102 arp102 self-assigned this Mar 29, 2024
@arp102 arp102 self-requested a review March 29, 2024 16:33
@arp102 arp102 removed their assignment Mar 29, 2024
@arp102
Copy link
Contributor

arp102 commented Mar 29, 2024

The change looks good, just like #689.

But it leaves two unused variables in the code:

kmip/services/server/crypto/engine.py:587:13: F841 local variable 'backend' is assigned to but never used
kmip/services/server/crypto/engine.py:1442:9: F841 local variable 'backend' is assigned to but never used

The load_der_public_key method and the load_pem_private_key method were
removed from Backend class in cryptography 42.0.0[1].

Closes OpenKMIP#713

[1] pyca/cryptography@41daf2d
@kajinamit
Copy link
Contributor Author

Oops. Sorry I forgot executing pep8. Fixed the both errors.

@arp102 arp102 merged commit 4d3b5a5 into OpenKMIP:master Mar 29, 2024
22 checks passed
@kajinamit
Copy link
Contributor Author

May I request a new release so that the fix is consumable via pip ? You might want to merge #715 to reflect the versions currently tested.

@kajinamit kajinamit deleted the cryptography-42 branch March 29, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature Verification Issue Due to Missing Cryptography Backend Functions
4 participants