Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panacea: Fixing Gummi crash, implementing BASS_VGMStream for KH2 titl… #861

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

MainMemory
Copy link
Collaborator

…e/results/gummi music.

I did not modify the build process at all. All the DLL files in the OpenKh.Research.Panacea/Dependencies folder need to be copied to the build, as well as being copied into the game's folder alongside the Panacea DLL (DBGHELP.DLL).

Copy link
Collaborator

@TopazTK TopazTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based. Requesting @Vladabdf for a legal review.

@Vladabdf
Copy link
Collaborator

Vladabdf commented Sep 4, 2023

Has it been tested? @TopazTK

@TopazTK
Copy link
Collaborator

TopazTK commented Sep 4, 2023

@Vladabdf I am a dumb-dumb and cannot build this. I fully anticipate that @MainMemory has tested this through and through, and realize that someone else will have to as the build script needs editing anyways.

@shananas
Copy link
Collaborator

shananas commented Sep 4, 2023

I plan on updating mod manager for this and testing it I asked about possible loading the extra dlls from a subfolder as to not bloat the game install bug that'd be a nice to have. I plan on testing soon myself and updating mod manager also

@MainMemory
Copy link
Collaborator Author

Yeah I tested it, it seems to work properly, more or less.

@shananas
Copy link
Collaborator

shananas commented Sep 4, 2023

It should be known this should be merged with a Mod Manager update as according to #developers-only if the extra .dlls are not copied it will crash. I should be able to put it together tomorrow but if someone else wishes to make the changes before then to mod manager so they can be merged together I'm fine with that

Copy link
Collaborator

@shananas shananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge after #862 so mod manager has proper error handling and the game does not crash because its missing dependencies

Copy link
Collaborator

@TopazTK TopazTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based.

@Vladabdf Vladabdf merged commit 07402d5 into OpenKH:master Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants