Fix build #2
Open
Fix build #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can announce maintenance policy in README.
activerecord on travis.
Fix trailing spaces on files.
Now it looks like what a gem generated with `bundle gem` would look like. Also: - Change requirements back to ActiveRecord 3.1, seen as the gem is not ready for prime time with Rails 4; - Silence tests; - Indicate which license this gem has.
Modernized the gem, and a few other tweaks.
- Add build status badge - Mention that the gem also works for Rails 3.1
Testing with AR 3.1 and 3.2
Add Zachary to the authors and change the gem homepage.
between patch level releases.
The values of the result hash are all reflection objects. Adding a boolean there breaks stuff.
Remove #unscoped to avoid clearing the where_values prematurely.
The dependent destroy callback mechanism in Rails calls destroy! instead of destroy for has_many associations. With the existing implementation of acts_as_paranoid, this would unintentionally cause dependent objects to be hard-destroyed. This change makes destroy and destroy! identical, and adds a separate destroy_fully! method for full destroy.
By merging the scope, the original code would re-apply the default non-deleted scope, causing the scope to always return zero records. Use regular scope chaining instead.
This is to avoid conflict with minitest versions required by the different versions of Rails.
Conflicts: lib/acts_as_paranoid/core.rb
… delete to paranoid associations" see: 51cc825
…back returns false" see: cb800f2
…r the main model first and then its dependents" see: 60c236e?diff=split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.