0.5.0.beta1 opengov #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can announce maintenance policy in README.
activerecord on travis.
Fix trailing spaces on files.
Now it looks like what a gem generated with `bundle gem` would look like. Also: - Change requirements back to ActiveRecord 3.1, seen as the gem is not ready for prime time with Rails 4; - Silence tests; - Indicate which license this gem has.
Modernized the gem, and a few other tweaks.
- Add build status badge - Mention that the gem also works for Rails 3.1
Testing with AR 3.1 and 3.2
Add Zachary to the authors and change the gem homepage.
between patch level releases.
Fixed minor spelling mistake
- Get rid of observers tests (I tried to use rails-observer gems but it was a mess) - Update deprecated calls like #scope or #default_scope without block - Get rid of attr_protected call and tests - Get rid of AR#destroy! NoMethodError test The last one cause issue because in AR 4 #destroy! bang is defined. It's the same as #destroy but raise an AR::RecordNotFound if the record is not present in database. It may be smart to find another name for this method. But for now it just works. Conflicts: Gemfile Gemfile.lock acts_as_paranoid.gemspec test/test_observers.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged ActsAsParanoid/master into v0.4.2-opengov