Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globally set RDKit to include all properties when pickling an RDKit Mol #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Globally set RDKit to include all properties when pickling an RDKit Mol #344

wants to merge 1 commit into from

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Sep 11, 2024

Closes #322.

IAlibay
IAlibay reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see more tests on this please - it's not immediately clear to me that this doesn't change the behaviour and I would like to be sure it doesn't.

IAlibay
IAlibay requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant this as a request changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDKit Mol doesn't preserve atom properties when pickled; impacts ExplicitMoleculeComponent and subclasses
2 participants
@dotsdl @IAlibay