Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fix to dag ordering #315

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Proposed fix to dag ordering #315

wants to merge 3 commits into from

Conversation

LilDojd
Copy link

@LilDojd LilDojd commented Apr 27, 2024

Not sure how to add tests for this behavior. Please check if you can reproduce the original issue #314

@pep8speaks
Copy link

pep8speaks commented Apr 27, 2024 •
edited
Loading

Hello @LilDojd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 50:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-05-01 14:47:04 UTC

@dotsdl dotsdl linked an issue Oct 4, 2024 that may be closed by this pull request
ProtocolDAG._iterate_dag_order is unstable #314
Open
@dotsdl dotsdl self-requested a review October 4, 2024 14:56
@dotsdl dotsdl added this to the Release 1.1 milestone Oct 4, 2024
@dotsdl dotsdl requested review from ianmkenney and removed request for dotsdl October 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmkenney ianmkenney Awaiting requested review from ianmkenney

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
gufe : advancement sprints
Status: Sprint - In Review
Milestone
Release 1.1
Development

Successfully merging this pull request may close these issues.

ProtocolDAG._iterate_dag_order is unstable
4 participants
@LilDojd @pep8speaks @dotsdl @mikemhenry