Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Transformation and NonTransformation subclass TransformationBase #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make Transformation and NonTransformation subclass TransformationBase #311

wants to merge 3 commits into from

Commits on Apr 25, 2024

  1. Make Transformation and NonTransformation subclass `Transformatio… 

    …nBase`

In some cases it can be awkward for `NonTransformation` to be a subclass
of `Transformation`, such as in `alchemiscale`, for cases where
`NonTransformation` should be handled very differently. Switching to a
shared, abstract base class for `Transformation` and `NonTransformation`
simplifies this.
    @dotsdl
    dotsdl committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fb4a688 View commit details
    Browse the repository at this point in the history

  2. Address mypy complaints

    @dotsdl
    dotsdl committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0366d0e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into transformation-base-class

    @dotsdl
    dotsdl authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    349a344 View commit details
    Browse the repository at this point in the history