Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.5.0 prep #283

Merged
merged 19 commits into from
Aug 12, 2024
Merged

release 0.5.0 prep #283

merged 19 commits into from
Aug 12, 2024

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Jul 23, 2024

  • Update prod envs to use Python 3.11
  • Update all envs to use gufe 1.0.0, openfe 1.0.1

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (5a32969) to head (842a9cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   80.33%   80.30%   -0.03%     
==========================================
  Files          27       27              
  Lines        3452     3458       +6     
==========================================
+ Hits         2773     2777       +4     
- Misses        679      681       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Collaborator

Don't forget to add curl to the env

@dotsdl
Copy link
Member Author

dotsdl commented Aug 12, 2024

Seeing no issues with Python 3.12 use in my live testing. @mikemhenry, @IAlibay, @j-wags can you remind me what reservations we had for using it?

I believe there might have been something related to ambertools?

@IAlibay
Copy link
Member

IAlibay commented Aug 12, 2024

I think it was ambertools / openmmforcefields but that's fixed now. At least OpenFE runs CI on 3.12 just fine.

Only dependency I'm not sure about is oechem, since we don't use it that much in our tests.

@dotsdl
Copy link
Member Author

dotsdl commented Aug 12, 2024

Okay cool, this is great news! I think we can proceed with Python 3.12 and see if we actually hit any issues from users.

@dotsdl dotsdl merged commit 79ec027 into main Aug 12, 2024
5 checks passed
@dotsdl dotsdl deleted the release-0.5.0-prep branch August 12, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants