Changes needed to support execution via alchemiscale-fah
#218
Conversation
dotsdl
changed the title
dotsdl
changed the title
alchemiscale-fah
dotsdl
added this to the Release 0.4.0 - new features, optimizations, targeted refactors milestone
|
@ianmkenney can I get a review on this one? I'll keep it [WIP] for now as we finish things out over on OpenFreeEnergy/alchemiscale-fah#7, but getting a review sooner than later here will help us address clear gaps. |
| count=count, | ||
| protocols=protocols, | ||
| ) | ||
| tasks = self._post_resource("/claim", data) | ||
|
|
||
| return [ScopedKey.from_str(t) if t is not None else None for t in tasks] |
There was a problem hiding this comment.
See the comment on the claim endpoint. t can't be None
There was a problem hiding this comment.
Ah, this is an oversight on my part. Ideally we'd like the API call to always given back a list of length count, even if some elements must be None. This is to mimic the behavior of the older claim_taskhub_tasks method.
I've adjusted the return statement of the compute API claim_tasks endpoint to reflect this.
| @@ -187,13 +190,91 @@ def claim_taskhub_tasks( | |||
| taskhub=taskhub_scoped_key, | |||
| compute_service_id=ComputeServiceID(compute_service_id), | |||
| count=count, | |||
| protocols=protocols, | |||
There was a problem hiding this comment.
Note that n4js.claim_taskhub_tasks has protocols typed as Protocols, not str.
There was a problem hiding this comment.
Thanks for your fixes in #279!
There was a problem hiding this comment.
@dotsdl added some comments. Do you know what's happening on the latest failed CI?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 81.63% 80.23% -1.40%
==========================================
Files 26 27 +1
Lines 3371 3451 +80
==========================================
+ Hits 2752 2769 +17
- Misses 619 682 +63 ☔ View full report in Codecov by Sentry. |
* New protocols: DummyProtocolA, DummyProtocolB, DummyProtocolC * network_tyk2 now uses a variety of protocols for testing purposes
* Test if Tasks can be claimed by Protocol * Test if Tasks can be claimed by many Protocols
…-claim Test TaskHub Task claiming by Protocol
dotsdl
changed the title
alchemiscale-fahalchemiscale-fah
Co-authored-by: Ian Kenney <[email protected]>
Co-authored-by: Ian Kenney <[email protected]>
|
Thanks so much @ianmkenney! I'm going to merge; any additional changes made to support |
Includes all functionality needed for initial support of
alchemiscale-fah, developed here: OpenFreeEnergy/alchemiscale-fah#7Also closes:
pydanticmodels for encodingSynchronousComputeServicesettings #107