Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmptyCollectionWriter for MultipartFormContentProcessor #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

darrenfoong
Copy link

This PR adds an EmptyCollectionWriter to MultipartFormContentProcessor in SpringFormEncoder. This Writer is a no-op.

This is related to spring-cloud/spring-cloud-openfeign#352. Although the problem could have been fixed in spring-cloud-openfeign, it was agreed that doing it upstream here would be better.

In spring-cloud-openfeign, SpringFormEncoder is a "delegate" of SpringEncoder, while in this repository (feign-form-spring's unit tests), (an older version of) SpringEncoder is a delegate of SpringFormEncoder. What this means is that the unit tests in feign-form-spring do not exactly reflect the actual use in spring-cloud-openfeign, so it is not meaningful to add a unit test in this PR as it would pass even without the EmptyCollectionWriter.

@nkonev
Copy link

nkonev commented Feb 8, 2021

Hi @kdavisk6
Could you review and merge this PR ?

I can finalize it if need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants