Adding function to check sea surface elevation #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2021 17:54
To then be used in surface_stick()
knutfrode
reviewed
Nov 9, 2021
| self.environment.sea_surface_height | ||
| if 'sea_surface_height' not in locals(): | ||
| env, env_profiles, missing = \ | ||
| self.get_environment(['sea_surface_height'], |
There was a problem hiding this comment.
This does not work, since not all sublclasses of OceanDrift (nor OceanDrift itself) have a required variable sea_surface_height
Instead this method could return self.environment.sea_surface_height whenever it is available, otherwise 0
There was a problem hiding this comment.
True @knutfrode ...or maybe it makes sense to have sea_surface_height as a required variable for OceanDrift, with fallback zero ? like for wind, and waves.
Happy either way let me know and I can update the pull request accordingly.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To then be used in surface_stick()