Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: Add GitHub action to publish to PyPI #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Jun 18, 2022

No description provided.

Requires adding long_description to setup.py to make the checks pass.
@odscjames
Copy link
Contributor

if: startsWith(github.ref, 'refs/tags')

Would be nice to have something to check the tag is a version number format - we don't currently use tags for anything else, but I'm just thinking of safeguards. It would be easy for someone to forget this existed and just use a tag for something else.

@odscjames
Copy link
Contributor

Also just noticed differences between test and real publishing sections. I think the intention is that as soon as a commit with a new version is done, that will be published to test site. We can then test? Then only when we approve, merge and tag, does it go on real one. Is that correct? Does this (and skip_existing) mean if a PR with a new version is rejected due to a problem and a new PR is made, the new PR won't be put on test site? (Does that matter?) Can all this be (intention, procedure, what/how we test) be written up somewhere?

@Bjwebb Bjwebb changed the title sort_xml: Handle extensions in the schema xsd correctly when sorting @Bjwebb github actions: Add GitHub action to publish to PyPI Jul 4, 2022
@Bjwebb Bjwebb changed the title @Bjwebb github actions: Add GitHub action to publish to PyPI github actions: Add GitHub action to publish to PyPI Jul 4, 2022
@Bjwebb Bjwebb changed the base branch from main to cove-1366-org-file-ordering-no-gha-change July 5, 2022 10:39
@Bjwebb Bjwebb changed the base branch from cove-1366-org-file-ordering-no-gha-change to main July 5, 2022 10:39
@jpmckinney
Copy link
Contributor

This is the same as what we do (https://ocp-software-handbook.readthedocs.io/en/latest/python/packages.html#release-process). Every single push (on: push) gets published to TestPyPI. This ensures that the publication process isn't broken. Until you change the version number skip_existing will trigger. However, it's a bit of a misnomer as it still uploads to PyPI, it just doesn't replace the uploaded artifacts (e.g. ocdskit-1.1.3-py3-none-any.whl) and warns instead of erroring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants