[PATCH v3] validation: pktio: lso: filter non-test packets away earlier #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
test/validation/api/pktio/lso.c
Outdated
Comment on lines
341
to
346
| if (is_test_pkt(pkt)) { | ||
| pkt_out[num] = pkt; | ||
| num++; | ||
| } |
There was a problem hiding this comment.
Free the non-test packets.
test/validation/api/pktio/lso.c
Outdated
| static void update_ipv4_hdr(uint8_t *hdr, uint32_t hdr_len, uint32_t orig_pkt_len, | ||
| odp_packet_t pkt, uint16_t seg_num, uint16_t seg_offset) | ||
| static void update_ipv4_hdr(uint8_t *hdr, uint32_t hdr_len, odp_packet_t pkt, | ||
| uint16_t seg_num, uint16_t seg_offset, uint16_t num_segs) | ||
| { | ||
| (void)seg_num; |
There was a problem hiding this comment.
seg_num is used, so this could be removed.
There was a problem hiding this comment.
removed in v2
JannePeltonen
force-pushed
the
lso-test-imp
branch
from
53c7238 to
bc16603
Compare
odpbuild
changed the title
Ignore non-test packets already at packet reception time to simplify the segment checking phase. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Jere Leppänen <[email protected]>
JereLeppanen
approved these changes
Dec 13, 2024
JannePeltonen
force-pushed
the
lso-test-imp
branch
from
bc16603 to
c9f867f
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore non-test packets already at packet reception time to simplify the segment checking phase.