[PATCH v7] api: pktio: lso: promise maximum payload size for custom proto #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
JannePeltonen
force-pushed
the
api-lso-segsizes
branch
from
1872a13 to
14c3be6
Compare
odpbuild
changed the title
JannePeltonen
changed the title
JannePeltonen
force-pushed
the
api-lso-segsizes
branch
from
14c3be6 to
64ff831
Compare
odpbuild
changed the title
JannePeltonen
force-pushed
the
api-lso-segsizes
branch
from
64ff831 to
1cf8bf9
Compare
odpbuild
changed the title
|
v4: rebased |
MatiasElo
approved these changes
Dec 16, 2024
psavol
approved these changes
Dec 16, 2024
JannePeltonen
force-pushed
the
api-lso-segsizes
branch
from
1cf8bf9 to
0b0bf9a
Compare
odpbuild
changed the title
|
v5: added review tags |
|
Reviewed-by: Nithin Dabilpuram [email protected] |
MatiasElo
added
the
API Ready
JannePeltonen
force-pushed
the
api-lso-segsizes
branch
from
0b0bf9a to
18700d6
Compare
odpbuild
changed the title
|
v6: review tag |
Specify that all segments, except the last one, have the maximum payload length with the custom protocol. Rounding down the payload length by ODP implementations would be problematic for certain custom protocols that need to know the exact length of the segments in advance. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]> Reviewed-by: Nithin Dabilpuram <[email protected]>
Check that the non-last segments of a custom LSO protocol have the maximum payload length as promised by the API. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Matias Elo <[email protected]> Reviewed-by: Nithin Dabilpuram <[email protected]>
MatiasElo
force-pushed
the
api-lso-segsizes
branch
from
18700d6 to
357a6a2
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that LSO for the custom protocol produces same-sized segments (except the last segment).
Add a profile parameter to request exactly maximum length payload sizes in the non-last segments produced by the custom protocol LSO.
v2:
Remove configurability and the capability flag and just promise that the custom LSO protocol always produces maximum length segments.
v3:
Added validation test commit.