[PATCH v3] api: cls: clarify back pressure configuration #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Nov 27, 2024
MatiasElo
reviewed
Dec 16, 2024
JannePeltonen
force-pushed
the
api-bp
branch
from
892f3ae to
6c9c3ea
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Dec 16, 2024
psavol
approved these changes
Dec 16, 2024
Description of the back pressure configuration in classifier is somewhat ambiguous as it leaves many details out. Clarify the presumed intent of the API by specifying how exactly the back pressure threshold for any given pktio + pool/queue + pfc_level -tuple is derived from the configuration. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]>
JannePeltonen
force-pushed
the
api-bp
branch
from
6c9c3ea to
3567129
Compare
odpbuild
changed the title
|
v3: added review tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the back pressure configuration in classifier is somewhat ambiguous as it leaves many details out. Clarify the presumed intent of the API by specifying how exactly the back pressure threshold for any given pktio + pool/queue + pfc_level -tuple is derived from the configuration.