Skip to content

Commit

Permalink
build: ignore x86_32 PIC related globals in check_globals
Browse files Browse the repository at this point in the history
Make the check_globals script of make check allow  .*get_pc_thunk.*
symbols that are used in PIC code in 32-bit x86.

Signed-off-by: Janne Peltonen <[email protected]>
Reviewed-by: Jere Leppänen <[email protected]>
  • Loading branch information
JannePeltonen authored and MatiasElo committed Aug 26, 2024
1 parent de4066f commit d506c65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion helper/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ __LIB__libodphelper_la_LIBADD += $(LIBCLI_LIBS)

lib_LTLIBRARIES = $(LIB)/libodphelper.la

CHECK_GLOBALS_REGEX = " (odph_|_deprecated_odph_|__odr_asan)"
CHECK_GLOBALS_REGEX = " (odph_|_deprecated_odph_|__odr_asan|__.*get_pc_thunk.*)"

TESTS_ENVIRONMENT = \
LIBTOOL="$(LIBTOOL)" \
Expand Down
2 changes: 1 addition & 1 deletion platform/linux-generic/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ if ODP_PKTIO_PCAP
__LIB__libodp_linux_la_LIBADD += $(PCAP_LIBS)
endif

CHECK_GLOBALS_REGEX = " (odp_|_odp_|_deprecated_odp_|miniz_|mz_|tdefl_|tinfl_|mp_hdlr_init_odp_pool_ops|__odr_asan)"
CHECK_GLOBALS_REGEX = " (odp_|_odp_|_deprecated_odp_|miniz_|mz_|tdefl_|tinfl_|mp_hdlr_init_odp_pool_ops|__odr_asan|__.*get_pc_thunk.*)"

TESTS_ENVIRONMENT = \
LIBTOOL="$(LIBTOOL)" \
Expand Down

0 comments on commit d506c65

Please sign in to comment.