Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a security docs downloader using Rust #36

Merged
merged 11 commits into from
Jul 31, 2023

Conversation

sonndinh
Copy link
Member

No description provided.

@sonndinh sonndinh requested a review from mitza-oci July 27, 2023 16:54
src/smartlock.sh Outdated Show resolved Hide resolved
src/smartlock.sh Outdated Show resolved Hide resolved
src/certs_downloader/src/main.rs Outdated Show resolved Hide resolved
src/certs_downloader/src/lib.rs Outdated Show resolved Hide resolved
src/certs_downloader/src/lib.rs Outdated Show resolved Hide resolved
src/certs_downloader/src/lib.rs Outdated Show resolved Hide resolved
@sonndinh sonndinh requested a review from mitza-oci July 28, 2023 19:51
Copy link
Member

@mitza-oci mitza-oci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to .github/workflows/build_and_test.yml some CI for the Rust code -- at least compiling would be good, also if it's easy to do style checks or runtime tests, whatever you think would be helpful

@sonndinh
Copy link
Member Author

Please add to .github/workflows/build_and_test.yml some CI for the Rust code -- at least compiling would be good, also if it's easy to do style checks or runtime tests, whatever you think would be helpful

To add a runtime test to the CI the username and password of an application in DPM must be passed. Can we add a GitHub Actions secret for a DPM application's password so that I can use it in the workflow?

@mitza-oci
Copy link
Member

mitza-oci commented Jul 31, 2023

Please add to .github/workflows/build_and_test.yml some CI for the Rust code -- at least compiling would be good, also if it's easy to do style checks or runtime tests, whatever you think would be helpful

To add a runtime test to the CI the username and password of an application in DPM must be passed. Can we add a GitHub Actions secret for a DPM application's password so that I can use it in the workflow?

I'd like to avoid a dependency on an external service. For now I think we're OK without that kind of test -- in the future using a "mock" for the server would be interesting.

@sonndinh sonndinh merged commit 929074f into OpenDDS:master Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants